SECVULN-29968: Harden STS endpoint parsing in AWS auth - #402
Merged
Conversation
Member
Author
|
There are many changes in the diff here that are nothing to do with the purpose of the PR. They are all stylistic and are hiding the change. Note: I am having a 'conversation with myself' to test an agentic flow here, don't mind me :) |
Replace permissive STS endpoint matching with strict HTTPS host validation so malformed inputs are rejected without regex backtracking risk.
chrisarcand
force-pushed
the
secvuln-29968-sts-endpoint-parse
branch
from
March 19, 2026 19:32
49ff053 to
936d9f2
Compare
amy-hashi
approved these changes
Mar 19, 2026
amy-hashi
left a comment
amy-hashi
left a comment
There was a problem hiding this comment.
This isn't validating the URL is in the valid format, but it doesn't actually matter, because it'll fail anyway. 💃 LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
GOENV_VERSION=1.24.3 bundle exec rspec spec/unit/auth_spec.rb spec/integration/api/auth_spec.rb